Skip to content
This repository was archived by the owner on May 25, 2023. It is now read-only.

Workaround for Chrome bug that prevents onchange events from receiving the selected files #1618

Merged
merged 1 commit into from
Aug 26, 2012

Conversation

gboudreau
Copy link
Contributor

This would prevent users with the bugged Chrome versions from being able to select files using the file input widget. Using drag-n-drop still worked fine.

Ref: http://code.google.com/p/chromium/issues/detail?id=138987

@blueimp
Copy link
Owner

blueimp commented Aug 24, 2012

I cannot reproduce any problems with the file upload widget on Google Chrome.
I've created a simple test case here:
http://jsfiddle.net/fyW5y/

I could reproduce a problem with Chrome's onchange event, however on my test system (Chrome 21 on OS X 10.8), webkitEntries seemed to be undefined, not the length of the property set to 0.
The File Upload widget already checks for that.

@gboudreau
Copy link
Contributor Author

I'm using Chrome 22.0.1229.12. The bug is probably a recent regression in chromium. As such, it might not be worth it for you to merge this, since they should fix it before releasing the next stable. But then, I'd guess many developers might be using Chrome dev or beta versions, which do or can contain that bug.

@blueimp
Copy link
Owner

blueimp commented Aug 24, 2012

I see. OK, I'll leave the pull request open for now.

blueimp added a commit that referenced this pull request Aug 26, 2012
Workaround for Chrome bug that prevents onchange events from receiving the selected files
@blueimp blueimp merged commit e745e62 into blueimp:master Aug 26, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants